Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rails 6 #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Shehbaz
Copy link

@Shehbaz Shehbaz commented Sep 1, 2020

No description provided.

@Shehbaz Shehbaz changed the title (WIP) Change gemspec and gemfile (WIP) Upgrade to rails 6 Sep 29, 2020
@Shehbaz Shehbaz changed the title (WIP) Upgrade to rails 6 Upgrade to rails 6 Oct 8, 2020
@LiChoi
Copy link

LiChoi commented Aug 4, 2021

I pulled from this branch but it's not working for me (I'm using Rails 6.1.3.2).
Whenever I try to query something on a table, this is the error I get

undefined method `ID' for #<Snowflake::Company:0x00007fe66381e650>
Did you mean?  id?
               id=

@hle-skillz
Copy link

I pulled from this branch but it's not working for me (I'm using Rails 6.1.3.2).
Whenever I try to query something on a table, this is the error I get

undefined method `ID' for #<Snowflake::Company:0x00007fe66381e650>
Did you mean?  id?
               id=

Might be similar to issue we saw on Rails 5 trying to use ActiveModel #33.

When following the instructions from the blog we had to add this to odbc.rb to change the id lookup in the adapter:

  # Possible bug with base adapter not fixing the case for primary key 'ID' in Snowflake.
  def primary_key(table_name)
    format_case(super || "ID")
  end

zokioki pushed a commit to doximity/odbc_adapter that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants