Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial changes in package 'org.locationtech.udig.project.internal.impl' #656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sschulz92
Copy link
Contributor

Following actions were made:

  • Add @Override automatically
  • Apply code-formatter
  • Remove unnecessary javadoc
  • Remove curly-braces for switch-case
  • Fix possible NullPointerException in ProjectImpl.java

@Override
public void notifyChanged(Notification msg) {
switch (msg.getFeatureID(RenderManager.class)) {
case RenderPackage.RENDER_MANAGER__VIEWPORT_MODEL_INTERNAL: {
case RenderPackage.RENDER_MANAGER__VIEWPORT_MODEL_INTERNAL:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the code looks much better but since it is a generated file I assume:

  • its reset after generation from EMF model again
  • its worth to find a way how the right formatter is applied after code-generation

I'd like to avoid efford the might be useless ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find the information which class is generated? Is there any documentation I may read regarding EMF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants