-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show monitor descriptions on status page #4612
base: master
Are you sure you want to change the base?
Conversation
- configure description visibility per monitor - configure description visiblitiy per status page
The next time around please have a discussion how to implement a new feature beforehand (see our contribution guide). This paragraph was added to safe us all time ^^ To the feature: => new relation |
@CommanderStorm sorry about that! 😬 Using settings sounds good, though I wonder if still keeping the status page level toggle might still make sense? From my ux perspective, the option to show the descriptions wouldn't be discoverable enough if it's hidden on he status page -> monitor settings level. Personally, if I wanted to show one monitor's description on a status page, I would want to show it for all the monitors. I would propose removing the This way, backwards-compatibility is still retained, while having an easily accessible way to enable showing all descriptions, just like the setting that already exists for tags. Then, if a user wants to hide the description for a monitor, they would logically go to its settings and toggle it off. |
This is another point where #4456 might be helpfull. I see this case as not so common => keeping this as a status page level setting makes sense to me.
I don't really see a reason for this if this is a status page level setting. |
Honestly, we were looking for this override today. We had to do some hacky stuff with CSS and Tags to achieve what we wanted. A override would be great. |
You are not looking for the proposed override, since we currently don't support descriptions on status pages. Could you give further context why you need to disable descriptions for a status page instead of not configuring the descriptions for said status page? |
I can. We now use the (single) description field for a technical description of all checks. The way we implemented exactly what @hmnd has built is via CCS with tags as workaround. This way we actually have 2 descriptions per monitor: a technical for the admin and an short explanation on user-level for the visitor. Nevertheless I would keep it simple and vote for this change. |
This would be really useful and help avoid using the hack with tags described in #3008 The monitor's description should live in the monitor, not in the status page. The status page can decide to show each monitor's description or not but it makes no sense to have separate descriptions. What might be useful is to have annotations in case there are certain outages but it's beyond the point here. |
Support showing monitor description on status page, with configurable visibility at the monitor and status page levels.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #3008
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)