Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Page: Display offline monitors at the top of the statuspage. #4689

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zandor300
Copy link
Contributor

@Zandor300 Zandor300 commented Apr 18, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Displays all offline monitors of the current status page at the top of the page in an "offline monitors" section.

Fixes #1936

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

@Zandor300
Copy link
Contributor Author

Zandor300 commented Apr 18, 2024

@louislam @CommanderStorm @chakflying

By default, the "Offline Monitors" section will always show up on all status pages. I would like to make this configurable but I am not sure where to start with adding the configuration option. Could you give me a couple of pointers on where to start?

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Apr 18, 2024

You have a very good point on how we should make this configurable.

Originally, I was under the assumption (have not communicated this part) that this should be a sorting button with a small popover on the right of the list which changes the monitor order from the current grouped version to be based on status(/uptime/name). State for which stored in the url.

I am unsure if users might find the disaperance of groups weird and thus a fixed section like proposed by you is better.

@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:status-page Everything related to the status page labels May 19, 2024
@github-actions github-actions bot added the pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again label Jun 17, 2024
@github-actions github-actions bot removed the pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:status-page Everything related to the status page pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status Page: Sort offline monitors at the top of the status page in 'offline' group
2 participants