added Incident report History #4943

MasonColoretti · 2024-07-15T00:39:47Z

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

I have read and understand the pull request rules.

Description

Added Incident Report History for the #1100
Fixes #1100

Type of change

Feature addition
Please delete any options that are not relevant.

New feature (non-breaking change which adds functionality)
Other
This change requires a documentation update

Checklist

My code follows the style guidelines of this project
I ran ESLint and other linters for modified files
I have performed a self-review of my own code and tested it
I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
My changes generates no new warnings
My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Incident report history list

Incident report history button

joebnb · 2024-07-16T01:51:39Z

if Incident history configurable to be visible on the status page would be even better

MasonColoretti · 2024-07-16T01:53:56Z

if Incident history configurable to be visible on the status page would be even better

definitely able to add this later on just trying to ge tthe base feature out

CommanderStorm

The status page currently manages incidents.
I would prefer to leave this as a status page concept and add the history there instead.

Having this as a concept like maintenance has advantages and downsides. Without the infra needed, this is currently somewhat confusing to new users as they have likely not figured out where incidents can be created.
If you want to add this to the admin UI as well, this needs better UX from this side. (split error+empty, add a helptext that incidents can be created on status pages)

CommanderStorm · 2024-07-16T12:54:08Z

package.json

@@ -49,7 +49,7 @@
        "build-docker-nightly-local": "npm run build && docker build -f docker/dockerfile -t louislam/uptime-kuma:nightly2 --target nightly .",
        "build-docker-pr-test": "docker buildx build -f docker/dockerfile --platform linux/amd64,linux/arm64 -t louislam/uptime-kuma:pr-test2 --target pr-test2 . --push",
        "upload-artifacts": "docker buildx build -f docker/dockerfile --platform linux/amd64 -t louislam/uptime-kuma:upload-artifact --build-arg VERSION --build-arg GITHUB_TOKEN --target upload-artifact . --progress plain",
-        "setup": "git checkout 1.23.13 && npm ci --production && npm run download-dist",
+        "setup": "npm ci --production && npm run download-dist",


please revert this change. the git checkout is intentional

CommanderStorm · 2024-07-16T12:57:58Z

src/pages/ListIncidents.vue

+                this.isLoading = false;
+            }
+        },
+        formatDate(dateString) {


please use the time handling mixin instead
See https://github.com/louislam/uptime-kuma/blob/master/src/mixins/datetime.js

CommanderStorm · 2024-07-16T12:59:33Z

src/pages/ListIncidents.vue

+        async fetchIncidentReports() {
+            this.isLoading = true;
+            try {
+                const response = await fetch("/api/incident-reports"); // Replace with your API endpoint


The rest of the admin UI uses socketio communication.
I don't see why this part of the UI should differ from that pattern => please use socketio as well for this ^^

Depending on what this page should do (main discussion), either a general handler or a dedicated handler is the way to go.

CommanderStorm · 2024-07-16T13:20:27Z

src/pages/ListIncidents.vue

@@ -0,0 +1,87 @@
+<template>
+    <div>
+        <h1>Incident Reports</h1>


Currently, our transaltors could not translate this string.
Please use {{ $t("Incident Reports") }} instead and add this key to the en.json.

There are a few other cases of this as well

MasonColoretti · 2024-07-17T05:56:41Z

The status page currently manages incidents.

I would prefer to leave this as a status page concept and add the history there instead.

Having this as a concept like maintenance has advantages and downsides. Without the infra needed, this is currently somewhat confusing to new users as they have likely not figured out where incidents can be created.

If you want to add this to the admin UI as well, this needs better UX from this side. (split error+empty, add a helptext that incidents can be created on status pages)

ok understandable i can do all of this however im not a ui-ux designer would you be able to more in depth describe how this should look

CommanderStorm · 2024-07-17T08:18:16Z

There are a few designs in

[Feature]: Incident Timeline #862
(also in this one) Feature Req: Multiple Incidents on Status Page #579

MasonColoretti · 2024-07-18T07:37:50Z

There are a few designs in

* [[Feature]: Incident Timeline #862](https://github.com/louislam/uptime-kuma/issues/862)

* (also in this one) [Feature Req: Multiple Incidents on Status Page #579](https://github.com/louislam/uptime-kuma/issues/579)

alot of enterprise solutions look something along the lines of this https://jira-service-management.status.atlassian.com/ would you be willing to use this or no?

CommanderStorm · 2024-07-18T10:40:09Z

alot of enterprise solutions look something

I think you are talking about the difference of having the incident history on a separate page vs on the same page but below.
I don't think that matters that much.

I would prefer that to be tucked away on a separeate page (I suspect that the regular user does not need to have this avaliable) and linked from the page, but if it is below that is fine by me.

MasonColoretti · 2024-07-18T19:05:34Z

alot of enterprise solutions look something

I think you are talking about the difference of having the incident history on a separate page vs on the same page but below. I don't think that matters that much.

I would prefer that to be tucked away on a separeate page (I suspect that the regular user does not need to have this avaliable) and linked from the page, but if it is below that is fine by me.

sounds good i will fix it up and put it on the status page instead

MasonColoretti · 2024-08-17T06:43:49Z

@CommanderStorm what do we think of it now... good to merge?

MasonColoretti · 2024-08-30T03:35:59Z

whats the status of this pr im considering closing and reopening

CommanderStorm · 2024-08-30T04:50:16Z

Sorry
I did not re-review this earlier, because this does not seem done.
You also did not address some of the other changes I requested. For example the request to do i18n...

Also: the API you are calling does not exist => have you tested the code?...

If you are asking about a merge or reject decision, that would be close, but things are not final.. the issues left are fixable, but require work..
I can't nurture this to health in master (among other things, because I am going on vacation next month) or fix the things that are left via code reviews.

MasonColoretti · 2024-08-30T05:10:43Z

Sorry
I did not re-review this earlier, because this does not seem done.
You also did not address some of the other changes I requested. For example the request to do i18n...

Also: the API you are calling does not exist => have you tested the code?...

If you are asking about a merge or reject decision, that would be close, but things are not final.. the issues left are fixable, but require work..
I can't nurture this to health in master (among other things, because I am going on vacation next month) or fix the things that are left via code reviews.

ok i will fix this up again thank you very much for understanding

MasonColoretti added 4 commits July 12, 2024 21:00

added all functionallity for incident history

407468f

fixed reports list sorting

fa1fa87

final commit and preping pr and merge

85712f8

Merge branch 'louislam:master' into master

78c2db2

MasonColoretti mentioned this pull request Jul 15, 2024

Is there a way to view incident history? #1100

Closed

2 tasks

MasonColoretti added 3 commits July 14, 2024 18:46

fixed lint format

49d9d19

fixed lint format

cad43c8

fixed lint format

edebe9b

This comment was marked as spam.

Sign in to view

CommanderStorm requested changes Jul 16, 2024

View reviewed changes

CommanderStorm added area:dashboard The main dashboard page where monitors' status are shown area:incidents Incidents shown in the status pages pr:please address review comments this PR needs a bit more work to be mergable labels Jul 16, 2024

Merge branch 'louislam:master' into master

2fa6d67

CommanderStorm mentioned this pull request Jul 19, 2024

is uptime kuma able to show muti incident event #4953

Open

2 tasks

MasonColoretti added 3 commits August 17, 2024 00:30

addressed issues and changes requested

7ae2f1b

Merge branch 'louislam:master' into master

faf7187

fixed lint error

2f096a9

removed incident history button

2b586e9

github-actions bot added the needs:resolve-merge-conflict label Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added Incident report History #4943

added Incident report History #4943

MasonColoretti commented Jul 15, 2024 •

edited

Loading

This comment was marked as spam.

joebnb commented Jul 16, 2024

MasonColoretti commented Jul 16, 2024

CommanderStorm left a comment

CommanderStorm Jul 16, 2024

CommanderStorm Jul 16, 2024

CommanderStorm Jul 16, 2024

CommanderStorm Jul 16, 2024

MasonColoretti commented Jul 17, 2024

CommanderStorm commented Jul 17, 2024

MasonColoretti commented Jul 18, 2024

CommanderStorm commented Jul 18, 2024

MasonColoretti commented Jul 18, 2024

MasonColoretti commented Aug 17, 2024

MasonColoretti commented Aug 30, 2024

CommanderStorm commented Aug 30, 2024 •

edited

Loading

MasonColoretti commented Aug 30, 2024

added Incident report History #4943

Are you sure you want to change the base?

added Incident report History #4943

Conversation

MasonColoretti commented Jul 15, 2024 • edited Loading

Description

Type of change

Checklist

Screenshots (if any)

This comment was marked as spam.

joebnb commented Jul 16, 2024

MasonColoretti commented Jul 16, 2024

CommanderStorm left a comment

Choose a reason for hiding this comment

CommanderStorm Jul 16, 2024

Choose a reason for hiding this comment

CommanderStorm Jul 16, 2024

Choose a reason for hiding this comment

CommanderStorm Jul 16, 2024

Choose a reason for hiding this comment

CommanderStorm Jul 16, 2024

Choose a reason for hiding this comment

MasonColoretti commented Jul 17, 2024

CommanderStorm commented Jul 17, 2024

MasonColoretti commented Jul 18, 2024

CommanderStorm commented Jul 18, 2024

MasonColoretti commented Jul 18, 2024

MasonColoretti commented Aug 17, 2024

MasonColoretti commented Aug 30, 2024

CommanderStorm commented Aug 30, 2024 • edited Loading

MasonColoretti commented Aug 30, 2024

MasonColoretti commented Jul 15, 2024 •

edited

Loading

CommanderStorm commented Aug 30, 2024 •

edited

Loading