MQTT monitor: Certificate based authentication #4977
Draft
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
The goal of this pull request is to implement certificate based authentication when monitoring services using MQTT.
Currently only username + password can be used for logging in with a MQTT broker.
According to the docs of the currently used
mqtt
library, theoptions
argument created here is passed directly totls.createSecureContext
. Thus simply adding options forca
,cert
andkey
should be sufficient.Database wise there already exists fields
tlsCa
,tlsCert
andtlsKey
in themonitor
table, so I assume we could re-use them?Configuration for these parameters is currently inside HTTP config block. I assume simply re-adding these thee parameters to the MQTT monitor editing UI is the simplest approach.
Alternatively one could try to move them out of the http monitoring type configuration.
Generally: What do you think @louislam? Can I / someone move forward with implementing this feature?
Type of change
Please delete any options that are not relevant.
Checklist