Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow TLS with remote docker when using public CA #5123

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: allow TLS with remote docker when using public CA #5123

wants to merge 2 commits into from

Commits on Sep 21, 2024

  1. fix: allow TLS with remote docker when using public CA 

    This provides a small fix that allows you to define docker hosts that
you can connect with in three different ways:

1. Mutual TLS, docker host uses non-standard CA
2. Mutual TLS, docker host uses standard CA
3. No Authentication, docker host uses non-standard CA
4. No authentication, docker host uses standard CA

In the previous implementation only condition 1 and 4 were allowed. This
makes condition 2 and 3 possible. The logic is a little messy, but it
works.

DCO-1.1 Signed-off-by: Patrick Wagstrom <[email protected]>
    @pridkett
    pridkett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    495bf51 View commit details
    Browse the repository at this point in the history

  2. fix: correct linter errors 

    I missed some of the `let` definitions for the ca, cert, and key when
establishing the docker TLS connection.

DCO-1.1 Signed-off-by: Patrick Wagstrom <[email protected]>
    @pridkett
    pridkett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f65453e View commit details
    Browse the repository at this point in the history