feat: improved tyings #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincelwt
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Hey @7HR4IZ3, good fix but the problem is we don't want to have the openai dependency in the src/types.ts as some people might not have it installed (that's why we put the monitorOpenAi part in a separate lunary/openai import.
If someone is using langchain without openai for example, this will throw an error
|
Oh alright. I've modified the code. |
vincelwt
deleted the
llm-1917-lunary-js-fix-type-error-when-adding-response_format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type support for other
openai.chat.completions.createarguments.