Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colcon plugins #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use colcon plugins #9

wants to merge 3 commits into from

Conversation

stelzo
Copy link

@stelzo stelzo commented May 27, 2024

This PR removes the CMake pipeline and uses ROS Rust colcon and ament plugins instead (#8 and #4).

Release builds work with colcon build --cargo-args --release and cleaning a package before building with colcon build --clean-build.
I am currently missing a simple solution for "installing" launch files. In CMake this could be done with

install(DIRECTORY launch
  DESTINATION share/${PROJECT_NAME}
)

but I haven't found an easy way with cargo yet. How would you rate the relevance for this @m-dahl ?

@m-dahl
Copy link
Owner

m-dahl commented Jul 4, 2024

I think keeping the old behaviour has some benefits (no additional dependencies, easy to install stuff as you mentioned). What to you think about something like this to show both approaches?

@stelzo
Copy link
Author

stelzo commented Jul 31, 2024

I think it is a good approach in theory but in practice it makes the repo a little bit more overhead when using it as a template. I wanted to look into an "ROS installation step" via build.rs but didn't do it yet. I am also waiting for colcon/colcon-cargo#22 so the plugins can be downloaded with pip rosdep.
It would reduce the overhead for adding Rust nodes in general and make the process more seamless. With installation and rosdep solved, I would prefer using only the colcon plugins and remove cmake completely. I would argue that dependencies installed via rosdep are ROS-toolchain-native and thus okay for the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants