Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated snap to Core24 #305

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .build-trigger.txt
Empty file.
25 changes: 25 additions & 0 deletions .github/workflows/test-snap-can-build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: 🧪 Test snap can be built on x86_64

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2

- uses: snapcore/action-build@v1
id: build

- uses: diddlesnaps/snapcraft-review-action@v1
with:
snap: ${{ steps.build.outputs.snap }}
isClassic: 'false'
# Plugs and Slots declarations to override default denial (requires store assertion to publish)
# plugs: ./plug-declaration.json
# slots: ./slot-declaration.json
36 changes: 15 additions & 21 deletions snap/snapcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,32 @@ description: |

license: MIT

base: core22
base: core24
grade: stable
confinement: strict
compression: lzo

architectures:
- build-on: amd64
- build-on: arm64
- build-on: armhf
- build-on: ppc64el
- build-on: s390x

assumes:
- command-chain

platforms:
amd64:
build-on: [amd64]
build-for: [amd64]
arm64:
build-on: [arm64]
build-for: [arm64]
s390x:
build-on: [s390x]
build-for: [s390x]

apps:
slides:
command: bin/slides
command-chain:
- bin/homeishome-launch
plugs:
- home
- ssh-keys
- ssh-public-keys
- network
- network-bind

parts:
slides:
source: https://github.com/maaslalani/slides
Expand All @@ -48,10 +47,5 @@ parts:
- go

override-pull: |
snapcraftctl pull
snapcraftctl set-version "$(git describe --tags | sed 's/^v//' | cut -d "-" -f1)"

homeishome-launch:
plugin: nil
stage-snaps:
- homeishome-launch
craftctl default
craftctl set version="$(git describe --tags | sed 's/^v//' | cut -d "-" -f1)"
Loading