VULN-25329: Update devdocs-theme dependency #4146

jeff-matthews · 2023-07-17T15:09:49Z

Description

~~This pull request (PR) deletes the pwa-devdocs/ directory from the project.~~

~~Documentation was migrated to the https://github.com/AdobeDocs/commerce-pwa-studio repo and that's where it is actively maintained. That's also the source that we deploy to production.~~

Reverting deletion of pwa-devdocs/ directory and limiting scope to addressing the devdocs-theme dependency for legacy deployments to devdocs.magento.com. We no longer deploy the contents of the pwa-devdocs directory to devdocs.magento.com.

Related Issue

VULN-25329

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

pwa-studio-bot · 2023-07-17T15:17:48Z

	Messages
📖	Associated JIRA tickets: VULN-25329.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 9a5217c

glo42707 · 2023-07-20T11:12:46Z

run lighthouse-desktop

pwa-test-bot · 2023-07-20T11:12:48Z

Successfully started codebuild job for lighthouse-desktop

glo42707 · 2023-07-20T11:13:34Z

run lighthouse-mobile

pwa-test-bot · 2023-07-20T11:13:36Z

Successfully started codebuild job for lighthouse-mobile

glo42707 · 2023-07-20T11:29:53Z

run cypress

pwa-test-bot · 2023-07-20T11:29:54Z

Successfully started codebuild job for cypress

pwa-studio-bot · 2023-07-20T11:52:06Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged Verify content: Error: Image size (1280x1869) different than saved snapshot size (1280x1658). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png Verify content: Error: Image was 2.0008840289507224% different from saved snapshot with 52989.81191550777 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png verify column content: Error: Image was 7.658328706604878% different from saved snapshot with 753726.5846410868 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Page-Builder-Column-Page.diff.png ,should apply mediaQuery styles: Error: Image was 2.4061142240380584% different from saved snapshot with 48168.4818738627 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Column-media-query-(Desktop).diff.png verify mocked google map api with two markers and click event: Error: Image was 2.621848037935426% different from saved snapshot with 53024.25471920605 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---2-Locations.diff.png verify divider content: Error: Image was 20.94891106307312% different from saved snapshot with 1016541.7195534105 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/divider.spec.js/__diff_output__/Page-Builder-Divider-Page.diff.png verify dynamic block content: Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/dynamicBlock.spec.js/__diff_output__/Page-Builder-Dynamic-Block-Snapshot.diff.png verify slider content: Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page.diff.png verify slider content 2: Error: Image was 2.485618757482233% different from saved snapshot with 49760.09902978832 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-2.diff.png verify slider content 3: Error: Image was 16.88772507716221% different from saved snapshot with 338078.7458647257 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-3.diff.png verify slider content 4: Error: Image was 21.63970511525014% different from saved snapshot with 433209.58464321564 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-4.diff.png verify slider content 5: Error: Image was 21.577861648502793% different from saved snapshot with 431971.52791370713 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-5.diff.png verify slider content 6: Error: Image was 21.54520702443923% different from saved snapshot with 431317.8084636538 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-6.diff.png verify slider content 7: Error: Image was 1.0082792778816185% different from saved snapshot with 67949.95709499804 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-7.diff.png verify slider content 8: Error: Image was 1.582977776215655% different from saved snapshot with 55822.12830046886 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-8.diff.png verify slider content 10: Error: Image was 7.634317979555516% different from saved snapshot with 268630.27361021587 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-10.diff.png verify slider content 11: Error: Image was 4.796009316593796% different from saved snapshot with 379322.1320605833 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-11.diff.png verify slider content 12: Error: Image size (1280x5234) different than saved snapshot size (1280x5014). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-12.diff.png ,should apply mediaQuery styles: Error: Image was 8.264763750401604% different from saved snapshot with 170743.40727229684 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Slider-media-query-(Desktop).diff.png verify banner content: Error: Image was 2.054961975679115% different from saved snapshot with 52712.24063054011 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page.diff.png verify banner content2: Error: Image was 40.75456985136245% different from saved snapshot with 2083504.0254251726 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page2.diff.png verify banner content3: Error: Image was 46.598965265993634% different from saved snapshot with 2382288.2210864457 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page3.diff.png verify banner content4: Error: Image was 1.2068824301607495% different from saved snapshot with 53048.758594201776 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page4.diff.png verify banner content7: Error: Image was 1.0861941871446734% different from saved snapshot with 53193.970688198664 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page7.diff.png verify banner content8: Error: Image was 1.3339226859671482% different from saved snapshot with 53186.165334882135 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page8.diff.png verify banner content9: Error: Image was 1.1697475861558115% different from saved snapshot with 53422.84015877038 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page9.diff.png verify banner content10: Error: Image size (1280x8574) different than saved snapshot size (1280x7834). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page10.diff.png ,should apply mediaQuery styles: Error: Image was 15.00671376852356% different from saved snapshot with 510180.2466457418 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Banner-media-query-(Desktop).diff.png verify smoke test content: TypeError: The following error originated from your application code, not from Cypress. Failed to execute 'unobserve' on 'IntersectionObserver': parameter 1 is not of type 'Element'. When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application verify smoke test cms block content: Error: Image was 1.2080820771527612% different from saved snapshot with 55730.27591754946 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/diff_output/Page-Builder-Smoke-Test-CMS-Block-Content.diff.png verify smoke test dynamic block content: Error: Image was 1.2080820771527612% different from saved snapshot with 55730.27591754946 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/diff_output/Page-Builder-Smoke-Test-Dynamic-Block-Content.diff.png should apply mediaQuery styles: Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/tabs.spec.js/diff_output/Tabs-media-query-(Desktop).diff.png verify block content: Error: Image was 1.4767211508248446% different from saved snapshot with 95190.62675909014 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Block-Page.diff.png verify block dynamic block content: Error: Image was 1.6018530634484884% different from saved snapshot with 58353.5848777523 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Dynamic-Block.diff.png verify block cms block content: Error: Image was 1.6018530634484884% different from saved snapshot with 58353.5848777523 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Block.diff.png verify block cms page content: Error: Image was 1.4488963140331323% different from saved snapshot with 55377.97623939755 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Page.diff.png verify row content: Error: Image was 32.489072635585195% different from saved snapshot with 5043967.513561764 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row.diff.png verify row content2: Error: Image was 8.715849362812767% different from saved snapshot with 1102687.4253061297 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row2.diff.png verify row video background3: Error: Image was 1.1634912324169688% different from saved snapshot with 48788.44515069427 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row-Video-Background3.diff.png ,should apply mediaQuery styles: Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Row-media-query-(Desktop).diff.png

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 29c6c87

pwa-studio-bot · 2023-07-20T11:52:12Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to use radio-boolean filter results in Category and Search pages: AssertionError: Timed out retrying after 30000ms: Expected to find content: 'No' within the element: [ , 1 more... ] and with the selector: '[data-cy="RadioGroup-root"] label[class^="radio-root-"]' but never did. user should be able to add and remove promotions from cart: AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found. user should be able to place an order as a registered customer: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetCustomerAfterCreateQuery`. No request ever occurred. https://on.cypress.io/wait Registered user should be able to sign in from toast suggestion in guest checkout page: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="Toast-root"]`, but never found it. should be able to edit a configurable product and place an order: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user can fill and submit payment form and place order with inline badge position: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user can fill and submit payment form and place order with default badge position: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user should be able to place an order as a guest with an specified Region and a credit card: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id="braintree-hosted-field-cardholderName"]`, but never found it. user should be able to add and remove products from wishlist: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait should be able to place an order in French store: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductOptions-Option-root"]`, but never found it. should display English text and USD currency accross app if Default Store View is selected: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait should display French text and EUR currency accross app if French Store View is selected: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductFullDetail-root"] [data-cy="ProductOptions-Option-root"] [data-cy="ProductOptions-Option-selectedLabel"]`, but never found it. should show USD currency across app if it is selected inside French Store View: AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="ProductFullDetail-root"] [data-cy="ProductFullDetail-productPrice"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 29c6c87

This reverts commit 29c6c87.

jeff-matthews · 2023-07-21T19:43:13Z

Reverting deletion of pwa-devdocs/ directory and limiting scope to addressing the devdocs-theme dependency for legacy deployments to devdocs.magento.com.

glo42707 · 2023-07-24T06:01:03Z

tested and working fine.
QA approved

glo82145 · 2023-07-28T15:31:23Z

run lighthouse-desktop

pwa-test-bot · 2023-07-28T15:31:25Z

Successfully started codebuild job for lighthouse-desktop

glo82145 · 2023-07-28T15:31:34Z

run lighthouse-mobile

pwa-test-bot · 2023-07-28T15:31:36Z

Successfully started codebuild job for lighthouse-mobile

VULN-25329: Removing obsolete docs directory

29c6c87

m2-community-project bot added the Progress: ready for review label Jul 17, 2023

jeff-matthews mentioned this pull request Jul 17, 2023

VULN-25329: Removing obsolete docs directory #4144

Closed

glo42707 self-assigned this Jul 20, 2023

m2-community-project bot added Progress: review and removed Progress: ready for review labels Jul 20, 2023

glo42707 requested review from glo42707 and glo82145 July 20, 2023 11:08

glo42707 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jul 20, 2023

glo42707 added version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jul 20, 2023

jeff-matthews added 2 commits July 21, 2023 14:32

Revert "VULN-25329: Removing obsolete docs directory"

a5830bc

This reverts commit 29c6c87.

VULN-25329: Updated git repo for devdocs theme

9a5217c

jeff-matthews changed the title ~~VULN-25329: Removing obsolete docs directory~~ VULN-25329: Update devdocs-theme dependency Jul 21, 2023

glo82145 approved these changes Jul 24, 2023

View reviewed changes

m2-community-project bot assigned glo82145 Jul 24, 2023

m2-community-project bot added Progress: approved and removed Progress: review labels Jul 24, 2023

glo82145 merged commit dbd7cc4 into magento:develop Jul 28, 2023
1 check passed

m2-community-project bot added Progress: done and removed Progress: approved labels Jul 28, 2023

jeff-matthews mentioned this pull request Jul 31, 2023

MAGREQ-8593: Removed reference to old GH org #4151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VULN-25329: Update devdocs-theme dependency #4146

VULN-25329: Update devdocs-theme dependency #4146

jeff-matthews commented Jul 17, 2023 •

edited

Loading

pwa-studio-bot commented Jul 17, 2023 •

edited

Loading

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

pwa-studio-bot commented Jul 20, 2023

pwa-studio-bot commented Jul 20, 2023

jeff-matthews commented Jul 21, 2023

glo42707 commented Jul 24, 2023

glo82145 commented Jul 28, 2023

pwa-test-bot bot commented Jul 28, 2023

glo82145 commented Jul 28, 2023

pwa-test-bot bot commented Jul 28, 2023

VULN-25329: Update devdocs-theme dependency #4146

VULN-25329: Update devdocs-theme dependency #4146

Conversation

jeff-matthews commented Jul 17, 2023 • edited Loading

Description

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented Jul 17, 2023 • edited Loading

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

glo42707 commented Jul 20, 2023

pwa-test-bot bot commented Jul 20, 2023

pwa-studio-bot commented Jul 20, 2023

Log

pwa-studio-bot commented Jul 20, 2023

Log

jeff-matthews commented Jul 21, 2023

glo42707 commented Jul 24, 2023

glo82145 commented Jul 28, 2023

pwa-test-bot bot commented Jul 28, 2023

glo82145 commented Jul 28, 2023

pwa-test-bot bot commented Jul 28, 2023

jeff-matthews commented Jul 17, 2023 •

edited

Loading

pwa-studio-bot commented Jul 17, 2023 •

edited

Loading