-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype of using Markdown for experiment copy #144
base: main
Are you sure you want to change the base?
Conversation
cool, so one thing i discovered when cleaning up all of this is that there was a lot of code rot around from the jspsych implementation. i've been trying to parcel out what is needed for lab.js. the notion of timeline that was in the code seems to be primarily a jspsych thing, right? and the params seem to be the important bits for lab.js. i would be happy to do convert the experiment files to md. should we map out how we would like the experiment folder to be arranged? should we keep the strings separate than the params and assets or have it as a unit |
closes #93 |
Yes! There's a lot of crufty confusing stuff around because of our two different experiment frameworks. There's gonna be two steps to reconciling this I see:
Re: your suggestion of keeping all experiment elements as a unit. After some thought I think that's the way to go. Before really diving into this, it's probably worth taking another look at lab.js's json experiment definitions and thinking about how we might want experiment customization to look in the future. How important is it for us to allow experiment in the short term? |
Priority is to get the app working ASAP and remove confusing jspsych remnants. We'll keep the custom builder feature in but convert redux to store complete labjs jsons for easier development of lab.js builder compatibility. |
Hey Teon, take a look at what I've started doing in this PR.
There's a whole lot of busy work to do converting what we have to markdown, but I think it will be good going forward. This will also require big changes in how experiment descriptions are handled in React, but we're planning to do that anyway