Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve static builds #2755

Merged
merged 19 commits into from
Aug 17, 2023
Merged

Conversation

AntoinePrv
Copy link
Member

No description provided.

@jonashaag
Copy link
Collaborator

@pavelzw

@AntoinePrv
Copy link
Member Author

This is back to the error we get on main (well other PRs since main is older), which I believe means we need to update the patch.

As an alternative, in conda-forge/micromamba-feedstock#136 I try to allow a way to use a local source. It works locally.

@AntoinePrv
Copy link
Member Author

@pavelzw any idea why we are seeing mamba-org/setup-micromamba#68 on OSX builds?

@AntoinePrv
Copy link
Member Author

AntoinePrv commented Aug 17, 2023

Great, this works! I added cleanup: none to setup-micromamba, I'm not sure why it is needed.
Emulation seems to not be a significant penalty!

@AntoinePrv AntoinePrv marked this pull request as ready for review August 17, 2023 09:13
@AntoinePrv AntoinePrv changed the title Improve static builds Fix and improve static builds Aug 17, 2023
@AntoinePrv
Copy link
Member Author

The remaining failures are unrelated

Copy link
Member

@Hind-M Hind-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! Is the umamba_tests failure on macos unrelated too?

@jonashaag
Copy link
Collaborator

@pavelzw any idea why we are seeing mamba-org/setup-micromamba#68 on OSX builds?

I created mamba-org/setup-micromamba#130

@AntoinePrv
Copy link
Member Author

Great thanks! Is the umamba_tests failure on macos unrelated too?

It was a spurious failure.

@AntoinePrv AntoinePrv merged commit 9438ac7 into mamba-org:main Aug 17, 2023
18 of 20 checks passed
@AntoinePrv AntoinePrv deleted the static-builds branch August 17, 2023 12:33
@AntoinePrv AntoinePrv self-assigned this Aug 17, 2023
cvanelteren pushed a commit to cvanelteren/mamba that referenced this pull request Aug 29, 2023
* Check that CI fails

* Run CI through conda-forge script

* Run conda-forge script in feddstock dir

* Try setting mamba source visible to conda-forge script

* Fix feedstock patch path

* Checkout TMP AntoinePrv repo

* Don't template micromamba-feedstock

* Fix checkout ref

* Extract static package

* TMP debug OSX build

* Set OSX out dir

* Disable cleanup

* Run Linux ppc64le and aarch64 builds on emulated arch

* Try running python on fedora

* Run docker in docker

* Try ubuntu

* Change repo to conda-forge

* Revert "Check that CI fails"

This reverts commit 3b1a7d2.

* Remove unused recipe fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants