Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CONDA_OVERRIDE_WIN environment variable #2815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop CONDA_OVERRIDE_WIN environment variable #2815

wants to merge 2 commits into from

Conversation

jonashaag
Copy link
Collaborator

Unsupported by Conda and not useful in Mamba.

JohanMabille
JohanMabille reviewed Sep 6, 2023
View reviewed changes
libmamba/include/mamba/core/util_os.hpp Outdated
@@ -38,7 +38,6 @@ namespace mamba

void run_as_admin(const std::string& args);
bool enable_long_paths_support(bool force, Palette palette = Palette::no_color());
std::string windows_version();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be removed.

@jaimergp
Copy link
Contributor

jaimergp commented Sep 6, 2023

Hm, apparently conda does not query for any version number for Windows. It just reports it as win=0=0. It makes sense to not allow overrides for something that is always the same but the libmamba implementation does query for ver. Is that necessary or, conversely, should conda do the same?

@jonashaag
Copy link
Collaborator Author

jonashaag commented Sep 6, 2023 •
edited
Loading

@jaimergp I'm also fine with changing the behavior in Conda. I just want both implementations to behave the same.

@jaimergp
Copy link
Contributor

jaimergp commented Sep 7, 2023

It looks like __win (or __unix) were never versioned in conda, so the easiest way to make both behave the same is to disable versioning in libmamba. It would also save the subprocess call on every process.

My main question is whether there are packaging strategies that require __win versions in the same way we depend on __glibc or __cuda. I am not aware of any.

@jonashaag
Copy link
Collaborator Author

Not that I am aware of.

@AntoinePrv
Copy link
Member

My main question is whether there are packaging strategies that require __win versions in the same way we depend on __glibc or __cuda. I am not aware of any.

Well if it was never versioned, how could they?

Maybe we should do the right thing and make it versioned in both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonashaag @jaimergp @AntoinePrv @JohanMabille