Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmd.exe tests #56

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jonashaag
Copy link
Collaborator

@jonashaag jonashaag commented May 13, 2022

Reproducer for #39

@wolfv
Copy link
Member

wolfv commented May 13, 2022

I think we need to check the %errorlevel%:

e.g.

if %errorlevel% neq 0 exit /b %errorlevel%

that should propagate the error properly

@jonashaag
Copy link
Collaborator Author

Thanks for the pointer, I wanted to avoid copy-pasting that a dozen times...

@jonashaag
Copy link
Collaborator Author

Why does it stop executing the cmd.exe commands? I thought there was no fail-fast in cmd.exe.

@jonashaag
Copy link
Collaborator Author

@tdegeus if you have time to investigate the bug source of the bug that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants