Fix Xcode 14 warnings. #4146
Merged
Fix Xcode 14 warnings. #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
commented
Sep 12, 2022
| mobileEventsManager.sendTurnstileEvent() | ||
|
|
||
| DispatchQueue.global().async { [weak self] in | ||
| guard let self = self else { return } |
There was a problem hiding this comment.
Fixes:
/Users/distiller/project/Sources/MapboxMobileEvents/MMELocationManager.m:60: warning run: This method can cause UI unresponsiveness if invoked on the main thread. Instead, consider waiting for the `-locationManagerDidChangeAuthorization:` callback and checking `authorizationStatus` first.
There was a problem hiding this comment.
Is it safe to be called from the background thread?
There was a problem hiding this comment.
I think so, but fix on MapboxMobileEvents will be needed. I've added ticket on their side in mapbox/mapbox-events-ios#348. Will all temporary comment as well.
MaximAlien
commented
Sep 12, 2022
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "images" : [ | |||
There was a problem hiding this comment.
Needed to fix build error when running NavigationViewExample.
S2Ler
approved these changes
Sep 13, 2022
ShanMa1991
pushed a commit
that referenced
this pull request
Sep 15, 2022
ShanMa1991
pushed a commit
that referenced
this pull request
Sep 15, 2022
ShanMa1991
pushed a commit
that referenced
this pull request
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes Xcode 14 related warnings.