Implement the "Underutilized network time" metric #4901
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4901 +/- ##
===========================================
- Coverage 87.99% 64.37% -23.63%
===========================================
Files 265 265
Lines 37974 38007 +33
Branches 2409 1570 -839
===========================================
- Hits 33417 24468 -8949
- Misses 3490 12620 +9130
+ Partials 1067 919 -148 ☔ View full report in Codecov by Sentry. |
| @@ -359,6 +360,10 @@ export class HandlerManager { | |||
| } | |||
|
|
|||
| handleEvent = (e: Event, eventName?: keyof Handler) => { | |||
| if (e.type === 'moveend' || e.type === 'zoomend' || e.type === 'rotateend') { | |||
There was a problem hiding this comment.
rollend? pitchend? bearingend?
| @@ -160,6 +161,7 @@ export class WorkerTile { | |||
| getPatternsPromise = actor.sendAsync({type: MessageType.getImages, data: {icons: patterns, source: this.source, tileID: this.tileID, type: 'patterns'}}, abortController); | |||
| } | |||
|
|
|||
| PerformanceUtils.mark(PerformanceMarkers.glyphsRequested); | |||
There was a problem hiding this comment.
I think this happens in the worker thread, not sure you reach it in the main thread...?
| @@ -173,8 +174,11 @@ export class SourceCache extends Evented { | |||
| } | |||
|
|
|||
| async _loadTile(tile: Tile, id: string, state: TileState): Promise<void> { | |||
| PerformanceUtils.mark(PerformanceMarkers.lastTileRequested); | |||
There was a problem hiding this comment.
Should this add some tileId data to the performance?
|
Thanks for taking the time to open this PR! |
Implement the "Underutilized network time" metric proposed in #4858
Launch Checklist
CHANGELOG.mdunder the## mainsection.