Bug 1914380 - broken search, TypeError: can't access property name, e…

…ngine is null in SearchModeSwitcher.sys.mjs. r=Standard8 a=graft Differential Revision: https://phabricator.services.mozilla.com/D219879 UltraBlame original commit: 4db772ac6fb4857ac32d5f6c14da0c3282cee956
marco-c · Aug 23, 2024 · 7bb58cc · 7bb58cc
1 parent abcf33a
commit 7bb58cc
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/toolkit/components/search/SearchSettings.sys.mjs b/toolkit/components/search/SearchSettings.sys.mjs
@@ -1596,6 +1596,11 @@ if
 engine
 .
 _isAppProvided
+&
+&
+engine
+.
+id
 )
 {
 let

diff --git a/toolkit/components/search/tests/xpcshell/test_settings_migrate_id_format.js b/toolkit/components/search/tests/xpcshell/test_settings_migrate_id_format.js
@@ -138,6 +138,43 @@ order
 1
 }
 }
+/
+/
+It
+is
+possible
+for
+inactive
+engines
+to
+not
+have
+an
+id
+even
+if
+the
+/
+/
+settings
+version
+is
+over
+6
+see
+bug
+1914380
+.
+{
+_name
+:
+"
+engine3
+"
+_isAppProvided
+:
+true
+}
 ]
 }
 ;