Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --vmaf parameter work independently again #881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damster101
Copy link
Contributor

Solves issue #824

@shssoichiro
Copy link
Collaborator

Needs a rustfmt please

@damster101
Copy link
Contributor Author

Needs a rustfmt please

Better now?

But someone really should run rustfmt on the entire project, I had to "fix" all those indentations to match the rest of the project...

@shssoichiro
Copy link
Collaborator

That's weird, it should already be correct for the rest of the project. The CI validates it on each MR.

@damster101
Copy link
Contributor Author

That's weird, it should already be correct for the rest of the project. The CI validates it on each MR.

It seems rustfmt behaves VERY differently when I run it on the whole context.rs file compared to just the isolated function. I did the latter and got a ton of changes everywhere, especially lots of two space indentations were increased in size to four spaces.
But, if I run rustfmt on the whole context.rs file, it seems to recognize that a different style is used and doesn't perform any of these changes.

Btw, I would have expected that this behavior could be influenced by the user for whole project files, but there doesn't seem to be an option for it...

@damster101
Copy link
Contributor Author

So, it looks like the way to get modern Rust formatting for a large project is to omit all the lines starting with use at the beginning of the Rust project files when formatting them with rustfmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants