Test speakers #217
Test speakers #217
Conversation
Make Mono speker produce proper test adio instead of pink noise
Test Speaker select random output on audio HW with several outputs. Make it use the the selected ouput instead.
There was a problem hiding this comment.
On my setup (HDMI sound from AMD video card over DP available but does not actually work, analog outputs from motherboard work), this had the effect of forcing the tested speakers to always be those chosen in the "output" tab, ignoring the device chosen in the "hardware" tab. This comes from effectively being able to set the chosen device in two different places, and the fact that these two settings can differ.
Might be better if these two were linked together between those tabs in the GUI, so the last device selected in either tab would always be the one actually used-or if the "Hardware" tab were renamed "Test Hardware" and also used only the device selected within itself.
We DO need to unbreak currently broken speaker tests so this might be better than the current defaults but I suspect it as it stands now we'd get confusion and bug reports over it
|
The fix is somewhat simplistic but the only thing I can muster. Considering Test Speaker is broken I think this is better |
|
OK, I will let the rest of the team decide what to do. We replace a major bug with a lesser one as this stands, I will let the others on the team weigh in on this. |
Well, I was asked to create a PR with these if you look at the issue tracker long time ago. It is a bit late to |
|
Not my call to do this solo, so called for other reviews. |
No description provided.