Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image diffs against previous build to CI results #130

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 29, 2023

Unfortunately, from what I've read, you can't upload an image from Actions, so you still need to download the build artifact to see the diff, but it's one less step to do yourself manually.

@QuLogic QuLogic force-pushed the diff-results branch 3 times, most recently from ae368f9 to 6bef95a Compare March 29, 2023 08:58
@QuLogic QuLogic marked this pull request as ready for review March 29, 2023 19:04
@QuLogic
Copy link
Member Author

QuLogic commented Apr 12, 2023

you still need to download the build artifact to see the diff

i.e., it's part of the build Artifact at the bottom of the Check: https://github.com/matplotlib/cheatsheets/actions/runs/4552134723?pr=130

@dstansby
Copy link
Member

I've merged master here to fire CI since the old artifacts had expired.

@dstansby
Copy link
Member

Would be nice to have the diffs in a more discoverable directory? It took me a while to work out they were in docs/_build/html. Also there seems to be non-zero diffs which doesn't seem right? e.g.:

handout-beginner-diff

@QuLogic QuLogic force-pushed the diff-results branch 4 times, most recently from c7376e4 to 5653a1e Compare January 30, 2024 05:36
@QuLogic
Copy link
Member Author

QuLogic commented Jan 30, 2024

OK, I moved it to a separate artifact to make it easier to find. Now with artifacts v4, we can generate a URL, and with build step summaries, we can put that all on the summary.

So you can see the summary dropped here: https://github.com/matplotlib/cheatsheets/actions/runs/7706808370#summary-21002939154

@story645
Copy link
Member

Is there a way to have the diffs show up as a standalone check/see which check in the actions run is the diff check?

@QuLogic
Copy link
Member Author

QuLogic commented Jan 30, 2024

I think the only way to do that would be to move it into a separate job that depends on the build one, download the artifacts from it, and run comparison from there.

@dstansby
Copy link
Member

I think worth getting this in as is - I opened #143 for making the diff check a seaparate run.

@dstansby dstansby merged commit d7522e1 into matplotlib:master Jan 30, 2024
3 checks passed
@QuLogic QuLogic deleted the diff-results branch January 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants