-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image diffs against previous build to CI results #130
Conversation
ae368f9
to
6bef95a
Compare
i.e., it's part of the |
I've merged |
c7376e4
to
5653a1e
Compare
OK, I moved it to a separate artifact to make it easier to find. Now with artifacts v4, we can generate a URL, and with build step summaries, we can put that all on the summary. So you can see the summary dropped here: https://github.com/matplotlib/cheatsheets/actions/runs/7706808370#summary-21002939154 |
Is there a way to have the diffs show up as a standalone check/see which check in the actions run is the diff check? |
I think the only way to do that would be to move it into a separate job that depends on the build one, download the artifacts from it, and run comparison from there. |
I think worth getting this in as is - I opened #143 for making the diff check a seaparate run. |
Unfortunately, from what I've read, you can't upload an image from Actions, so you still need to download the build artifact to see the diff, but it's one less step to do yourself manually.