Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comparing multiple baseline images #161

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TimoRoth
Copy link

As discussed in #149, this is our forward-ported code to deal with multiple valid baseline images.
It's not yet tested, just a mostly blind forward-port that deals with the new summary.

The failing compare with the lowest rms value will be used for the summary.
A shape-mismatch has infinitely low "rms" and will be preferred over any comparison mismatch.

@TimoRoth TimoRoth force-pushed the multi_baseline branch 2 times, most recently from 472d92a to ac84260 Compare May 26, 2022 16:22
@TimoRoth
Copy link
Author

Not entirely sure why the tests are failing. Some of those I'm relatively sure I didn't even touch?

The failing compare with the lowest rms value will be used for the summary.
A shape-mismatch has infinitely low "rms" and will be preferred over any comparison mismatch.
@ConorMacBride
Copy link
Member

Not entirely sure why the tests are failing. Some of those I'm relatively sure I didn't even touch?

This should be fixed by #162

@TimoRoth
Copy link
Author

Ah, yeah. Just confirmed that they're failing on master as well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants