[fix] : avoid the case that increservice may fill duplicated number in multi-CN #19031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensenojs
requested review from
XuPeng-SH,
triump2020,
m-schen,
zhangxu19830126,
daviszhen,
qingxinhome,
aressu1985 and
heni02
as code owners
背景这个bug fix的一个背景是想要重新争取优化掉对于下面的insert的主键去重的开销. create table t(a int auto-increment primary key, b int);
insert into t(b) values (1); -- 其他的CN上可能手动地插入了这个CN的incrService cache住的自增区间的值. 在主键去重开启的时候, 大不了 之前提过一次pr, 但被revert了, revert的原因是没有考虑到远端CN在执行的时候没有workspace的信息, 因此在Engine拿表和做检测的时候没有通过相关的防御性代码. relative相关tke的runner : https://github.com/matrixorigin/ci-test/actions/runs/11047965332 后续优化的选项控制的issue跟踪 : #15723 |
m-schen
approved these changes
Sep 26, 2024
daviszhen
approved these changes
Sep 27, 2024
qingxinhome
approved these changes
Sep 27, 2024
|
向旭哥请教了一下, 检测在preinsert算子内部做在一些场景下仍然会有问题. 要重新改一下, 后面会补充相关的集成测试. 这个pr暂时先不能合 update : https://github.com/matrixorigin/ci-test/actions/runs/11100985195 |
jensenojs
force-pushed
the
fix-16493
branch
from
0c8179b
to
c714101
Compare
jensenojs
force-pushed
the
fix-16493
branch
from
c714101
to
5473310
Compare
heni02
approved these changes
Sep 30, 2024
jensenojs
force-pushed
the
fix-16493
branch
from
acf01be
to
f733d9a
Compare
zhangxu19830126
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #16493
What this PR does / why we need it:
PrimaryKeysMayBeModified做检测, 在遇到这种情况会直接retry, 重新从incr service里面拿值.