Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(): private chart add image repo docs #5

Merged
merged 6 commits into from
Feb 4, 2024
Merged

Conversation

EZ4BRUCE
Copy link
Contributor

@EZ4BRUCE EZ4BRUCE commented Jan 31, 2024

What type of PR is this?

  • Feature
  • BUG
  • Alerts
  • Improvement
  • Documentation
  • Test and CI

Which issue(s) this PR related:

issue #

What this PR does / why we need it:

在 private chart 的 values.yaml 中添加镜像仓库修改的注释

@EZ4BRUCE EZ4BRUCE changed the title docs(): add image repo docs docs(): private chart add image repo docs Jan 31, 2024
Copy link
Collaborator

@xzxiong xzxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change chart.version
最后再mo-ctl 1.2.0 只release 一次。

@EZ4BRUCE
Copy link
Contributor Author

no need to change chart.version 最后再mo-ctl 1.2.0 只release 一次。

done

@@ -156,6 +186,8 @@ mo-ruler-stack:
enabled: false

grafana:
# image:
# repository: "registry.cn-hangzhou.aliyuncs.com/ack-cos/grafana"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺了 sidecar

@xzxiong xzxiong merged commit 13b8d24 into main Feb 4, 2024
3 checks passed
@xzxiong xzxiong deleted the bruce/add-docs branch February 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants