Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenizer problem with commas inside NMR peaks #18

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

JeffersonH44
Copy link

Hello,

I found a problem while you are reading NMR peaks when you have no whitespace between two elements, like this:

9.73 (s,1H)

This is parsed as a peak with an assignment instead of a peak with a multiplicity and a number, I also add some cases for other contexts when you have some coupling units.

@mcs07
Copy link
Owner

mcs07 commented Sep 3, 2017

Sorry I've taken so long to review this - there's some great stuff here. But could you create separate branches for each individual change so they can have separate, more focused Pull Requests?

That way you can also continue developing on your master branch and it won't appear in the pull request. I think you'll need to create a new branch from the last commit before your changes, then you can cherry pick some of your own commits into the branch.

Some help documentation here:
https://help.github.com/categories/collaborating-with-issues-and-pull-requests/
https://git-scm.com/docs/git-cherry-pick

@JeffersonH44
Copy link
Author

Ok, I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants