Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: stats: add random variable infrastructure #110

Closed
wants to merge 201 commits into from
Closed

Conversation

mdhaber
Copy link
Owner

@mdhaber mdhaber commented Sep 24, 2023

@tupui rv_infrastructure is the branch you should base your Array API work on. However, I see that there is some work in rv_continuous that was intended to make it into SciPy already - all the stuff in _zeros.py and test_zeros.py. Here's what I'd suggest:

  • You can begin to work on _distribution_infrastructure.py and test_continuous.py from rv_continuous.
  • Meanwhile, I'll submit a PR to SciPy main with the changes to _zeros.py and test_zeros.py. Sorry those didn't make it before you reviewed the bracketing PR; apparently I had refactored for clarity in this branch. Done.
  • After that merges, we'll rebase this branch on SciPy main. We'll also make sure to remove the duplicate hypothesis configuration. Done.
  • You might need to merge rv_continuous into your Array API branch again because it will have changed, but there shouldn't be any difficult merge conflicts. You should just be able to use theirs for all files except the ones you've modified.

How does that sound?

henry50 and others added 29 commits June 5, 2024 00:18
* Correct todense documentation

* Fix docstring for sparse matrices

* Added optional parameters to todense method

* Fix infinite recursion

Co-authored-by: Dan Schult <[email protected]>

* Remove array/matrix from array-only docstring

---------

Co-authored-by: Dan Schult <[email protected]>
Co-authored-by: CJ Carey <[email protected]>
…sparray (scipy#20889)

* make test_base uniformly use @ over * for matmul unless testing it

* flesh out inplace matmul tests

* fix test of dense @= due to numpy change in 1.25

* include review suggestions
Remove inadvertently copy and pasted duplicate lines

Fix non-working clang-17 install

Add missing sudo in clang-17 install

Add missing requirement

Fix invocation of python -m build

Remove incorrect use of false in Clang-17 workflow

Remove unnecessary parts of clang-17 CI job
BLD/DEV: special: Fix warning due to mixed initializers
Some assertions have atol/rtol configurable, and one assertion had them
hardcoded, and that was causing tolerance problems in a Debian build with
reference LAPACK.

closes scipy#20911
This is a follow-up to scipygh-20477, where HiGHS wasn't touched on
purpose to avoid a merge conflict in another PR.

Minor useful side benefit: it shrinks the size of `_highs_wrapper.so`
by 0.4%

Closes scipygh-20256
* ENH: stats: add array API support to combine_pvalues
DOC: update doctests to satisfy scipy-doctests==1.2.0

(the 1.2.0 version is not released yet, so testing this locally)
Allow the filter-warnings context manager to not receive
a (doc)test.

This is useful to filter out DeprecationWarnings which are
emitted during test discovery. Which is needed, e.g.
for numpy 1/2 transition where things deprecated in numpy 2
emit warnings on import.
to after checking if they are `None`.
@mdhaber mdhaber closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.