Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs data for URL #24997

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 8, 2024

Summary

the basic support of URL is first added in v7.0.0, later added to v6.13.0

URL class implement is added in v7.0.0, via nodejs/node#7448, and backlogged to v6.13.0
URL.prototype.toJSON() implement is added in v7.7.0, via nodejs/node#11236, and backlogged to v6.13.0
the issue for URL.prototype.searchParams which will return an empty list when init is got fixed in v7.3.0, via nodejs/node#9484, and backlogged to v6.13.0

Test results and supporting details

https://nodejs.org/docs/latest/api/globals.html#url
https://nodejs.org/docs/latest/api/url.html#class-url
https://nodejs.org/en/blog/release/v6.13.0/
https://nodejs.org/en/blog/release/v7.0.0/
https://nodejs.org/en/blog/release/v10.0.0/


image

image


image

image

image

Related issues

see also nodejs/node#55806
see also #24998

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 8, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 8, 2024 09:36
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one issue:

api/URL.json Show resolved Hide resolved
@caugner caugner added the nodejs Data about Node.js label Nov 12, 2024
@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Nov 13, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. nodejs Data about Node.js size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants