Update nodejs data for Worker
#25012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
This was referenced Nov 9, 2024
legendecas
reviewed
Nov 11, 2024
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
legendecas
reviewed
Nov 21, 2024
| "nodejs": { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": "Only support `transferList` parameter as an optional array of objects." |
There was a problem hiding this comment.
This is not as accurate as the original version though. I think the most accurate way to refer the supported types is https://nodejs.org/api/worker_threads.html#portpostmessagevalue-transferlist.
There was a problem hiding this comment.
How about:
Only support passing the second parameter as an optional array of objects, not support passing the second parameter as an options object.
Only support transferringArrayBufferandMessagePortobjects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update the data for
Worker, as there is already a ecmascript_modules field shows the ESM supportthe data for
errorevent is confirmed with the intial pr nodejs/node#20876the data for
messageerrorevent andterminate()method come from the documentation, also confirmed by release and impl prhttps://nodejs.org/zh-cn/blog/release/v12.19.0
https://nodejs.org/zh-cn/blog/release/v14.5.0
nodejs/node#33772
https://nodejs.org/zh-cn/blog/release/v12.5.0
nodejs/node#28021
Test results and supporting details
confirmed by landing PRs and release notes
also test in local node runtime:
Related issues