feat(http): Add Sec-WebSocket-* headers #25115
Open
+230
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:http 🚠
|
@bsmth We discussed the failing check in yesterday's BCD call, and the recommendation is to file an issue in w3c/browser-specs to add this RFC. |
1 task
|
Changes to browser-specs incoming in next release: |
caugner
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Nit: Extract these unrelated fixes to a separate PR.
| @@ -117,7 +117,7 @@ | |||
| "firefox": { | |||
| "version_added": "1.5", | |||
| "notes": [ | |||
| "Before Firefox 128, the `getBBox()` method retured an empty `DOMRect` when there is no fill ([bug 1019326](https://bugzil.la/1019326)).", | |||
| "Before Firefox 128, the `getBBox()` method returned an empty `DOMRect` when there is no fill ([bug 1019326](https://bugzil.la/1019326)).", | |||
There was a problem hiding this comment.
Nit: Extract these unrelated fixes to a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding data in for
Sec-WebSocket-*headers. I am copying over info fromapi.WebSocket.protocol_rfc_6455->browser-compat-data/api/WebSocket.json
Line 673 in 7f9f083
Test results and supporting details
I began testing using BrowserStack, but support goes so far back, it's probably easier to mirror the rfc_6455 compliance entry instead.
Other changes:
Related issues and pull requests