FF133 HTMLMediaElement add onwaitingforkey event handler #25119
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
8 tasks
caugner
reviewed
Nov 19, 2024
Comment on lines
+3576
to
+3581
| { | ||
| "version_added": "52", | ||
| "version_removed": "133", | ||
| "partial_implementation": true, | ||
| "notes": "`onwaitingforkey` content attribute not implemented." | ||
| } |
There was a problem hiding this comment.
Do you know why we keep this statement? What works in 52-132, and what doesn't work?
There was a problem hiding this comment.
@caugner So in 52-133 you can add a JavaScript handler for the waitingforkey event using addEventListener, but you can't use the onwaitingforkey attribute in HTML to add an inline handler for the event. Hence a partial implementation.
In 133 the onwaitingforkey attribute in HTML was added.
I did it this way because this seemed like a partial implementation. But we could pretend it was always a full implementation and just add a note to the other feature "notes": "version 133 adds support for onwaitingforkey content attribute."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF133 adds support for the
onwaitingforkeycontent attribute in https://bugzilla.mozilla.org/show_bug.cgi?id=1925952Verified using this test on browserstack FF132 and 133 - works on the later, stalls on the former for onwaitingforkey: https://wpt.live/encrypted-media/media-element-event-handler-attributes.html
I did this by marking the old event version as partial.
Related docs can be tracked in mdn/content#36558