Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data point for read-write and read-only storageTexture.access #25137

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add data point for read-write and read-only storageTexture.access #25137

wants to merge 10 commits into from
+401 −170

Conversation

chrisdavidmills
Copy link
Collaborator

@chrisdavidmills chrisdavidmills commented Nov 20, 2024 •
edited by caugner
Loading

Summary

Chrome 124 supports the readonly_and_readwrite_storage_textures language extension (see WGSLLanguageFeatures), which allows the "read-write" and "read-only" storageTexture.access types to be set when specifying storageTexture bind group entry types in a bind group layout.

This PR adds data points for both the language extension and the access types.

See https://developer.chrome.com/blog/new-in-webgpu-124#read-only_and_read-write_storage_textures for the data source.

Test results and supporting details

Spec PR: gpuweb/gpuweb#4326

Related issues

Project issue: mdn/content#36346.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 20, 2024
@chrisdavidmills chrisdavidmills mentioned this pull request Nov 20, 2024
Open
3 tasks
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 20, 2024
beaufortfrancois
beaufortfrancois reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

api/WGSLLanguageFeatures.json Outdated
"version_added": "124"
},
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be mirror as WebGPU on Chrome for Android was enabled in Chrome 121.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, in my last commit.

api/GPUDevice.json
"version_added": "124"
},
"chrome_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be mirror as WebGPU on Chrome for Android was enabled in Chrome 121.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, in my last commit

chrisdavidmills and others added 3 commits November 20, 2024 13:44
@chrisdavidmills
Fixes for beaufortfrancois review comments
e642046
@chrisdavidmills
Merge branch 'webgpu-readonly_and_readwrite_storage_textures-extensio…
e42049d 
…n' of github.com:chrisdavidmills/browser-compat-data into webgpu-readonly_and_readwrite_storage_textures-extension
@caugner
Merge remote-tracking branch 'origin/main' into webgpu-readonly_and_r…
81210b6 
…eadwrite_storage_textures-extension
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 21, 2024
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner
Revert "Merge remote-tracking branch 'origin/main' into webgpu-readon…
cc5587b 
…ly_and_readwrite_storage_textures-extension"

This reverts commit 81210b6, reversing
changes made to e42049d.
@github-actions github-actions bot added infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG dependencies ⛓️ Pull requests that update a dependency package or file. size:l [PR only] 101-1000 LoC changed and removed size:m [PR only] 25-100 LoC changed labels Nov 21, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 21, 2024
@caugner
Copy link
Contributor

caugner commented Nov 21, 2024

Apologies @chrisdavidmills, something went wrong when I tried to resolve the merge conflict.

Could you please git reset --hard e42049d994e031fe8a380fd81ce29ff36ea7d24d && git push --force to undo my mischief?

caugner
caugner reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I just added mirror support to my compact diff, and here's the output for this PR:

image

It looks like this PR not only adds data for read-write and read-only storageTexture.access, but also updates some versions for api.WGSLLanguageFeatures. Is this intentional, i.e. are these changes directly related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaufortfrancois beaufortfrancois beaufortfrancois left review comments

@caugner caugner caugner left review comments

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:svg 🖌️ Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project size:l [PR only] 101-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdavidmills @caugner @beaufortfrancois