-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datapoints for optional depthCompare and depthWriteEnabled properties #25158
base: main
Are you sure you want to change the base?
Add datapoints for optional depthCompare and depthWriteEnabled properties #25158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
api/GPUDevice.json
Outdated
], | ||
"support": { | ||
"chrome": { | ||
"version_added": "120" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooop, I've only got one comment from you, which says "Ditto". I'm assuming there's one missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was wondering why "notes": "Currently supported on ChromeOS, macOS, and Windows only."
was not present for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, they should be added to all datapoints and sub-data points. Added in last commit.
@chrisdavidmills If this is based on a spec change (I assume it is?), can you please link the spec PR in the description? 🙏 Otherwise it's hard for me as a reviewer to check the description and validate the PS: I checked both the content issue and the Chrome blog post, and they don't seem to link there. |
Added. For future reference, you can generally find the spec change links in the "dawn" issues, for example at https://developer.chrome.com/blog/new-in-webgpu-120#changes_to_depth-stencil_state, where it says "See issue dawn:2132". |
Summary
In Chrome 120, the
depthCompare
anddepthWriteEnabled
properties of thecreateRenderPipeline
/createRenderPipelineAsync
descriptors have been made optional when not needed. See https://developer.chrome.com/blog/new-in-webgpu-120#changes_to_depth-stencil_state.See gpuweb/gpuweb#4318 for spec change.
This PR adds a datapoint for this, for each method.
Test results and supporting details
Related issues
Project issue: mdn/content#36370