Unify desc format for SVG elements #36883
Open
+40
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyclouds2001
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:SVG
|
Thanks for this! I'm going to anticipate that Hamish will suggest also updating the SVG element page template to be explicit about this if we're going ahead with this format. I've updated the HTTP header template page with a quote block with how we expect the first sentence should look if you want to use that for inspiration. edit: also adding in Pepelsbey who might have opinions on the SVG intro format :) |
| @@ -7,7 +7,7 @@ browser-compat: svg.elements.textPath | |||
|
|
|||
| {{SVGRef}} | |||
|
|
|||
| To render text along the shape of a {{SVGElement("path")}}, enclose the text in a **`<textPath>`** element that has an {{SVGAttr("href")}} attribute with a reference to the {{SVGElement("path")}} element. | |||
| To render text along the shape of a {{SVGElement("path")}}, enclose the text in a **`<textPath>`** [SVG](/en-US/docs/Web/SVG) element that has an {{SVGAttr("href")}} attribute with a reference to the {{SVGElement("path")}} element. | |||
There was a problem hiding this comment.
This one doesn't look very consistent. Can it be reworded?
| @@ -7,7 +7,7 @@ browser-compat: svg.elements.a | |||
|
|
|||
| {{SVGRef}} | |||
|
|
|||
| The **\<a>** SVG element creates a hyperlink to other web pages, files, locations in the same page, email addresses, or any other URL. It is very similar to HTML's {{htmlelement("a")}} element. | |||
| The **`<a>`** [SVG](/en-US/docs/Web/SVG) element creates a hyperlink to other web pages, files, locations in the same page, email addresses, or any other URL. It is very similar to HTML's {{htmlelement("a")}} element. | |||
There was a problem hiding this comment.
HOw did you decide on this pattern? I ask because HTTP went the other way - such as
The HTTP Last-Modified ...
I have no problem with this, just interested in the thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Additional details
Related issues and pull requests