Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add "`" to encode CSS property names #36895

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Minor: add "`" to encode CSS property names #36895

merged 2 commits into from
Nov 22, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 21, 2024

These properties were missing their tic marks that make them <code>.

Also, 3 macro fixes.

@estelle estelle requested review from a team as code owners November 21, 2024 09:51
@estelle estelle requested review from sideshowbarker, chrisdavidmills and scottaohara and removed request for a team November 21, 2024 09:51
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:Accessibility Accessibility docs Content:SVG SVG docs Content:Performance Web performance docs Content:Meta Content in the meta docs Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (22 pages)
Flaws (3)

Note! 20 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCPeerConnection/generateCertificate_static
Title: RTCPeerConnection: generateCertificate() static method
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/AlgorithmIdentifier does not exist
    • /en-US/docs/Web/API/RTCCertificateExpiration does not exist

URL: /en-US/docs/Web/CSS/font-variant-ligatures
Title: font-variant-ligatures
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/contextual_forms does not exist
External URLs (1)

URL: /en-US/docs/Web/CSS/mask-image
Title: mask-image

@estelle estelle changed the title Encode CSS property names Minor: add "`" to encode CSS property names Nov 21, 2024
pepelsbey
pepelsbey approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@sideshowbarker sideshowbarker merged commit b692821 into main Nov 22, 2024
8 checks passed
@sideshowbarker sideshowbarker deleted the missingtics branch November 22, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@pepelsbey pepelsbey pepelsbey approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

@scottaohara scottaohara Awaiting requested review from scottaohara scottaohara is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Learn:CSS Learning area CSS docs Content:Meta Content in the meta docs Content:Performance Web performance docs Content:SVG SVG docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @pepelsbey @sideshowbarker