Document the new options available on the DocumentPictureInPicture.requestWindow() method #36902
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equestWindow() method
chrisdavidmills
requested review from
wbamberg
and removed request for
a team
chrisdavidmills
changed the title
wbamberg
reviewed
Nov 21, 2024
Comment on lines
+33
to
+37
| - : A boolean value; defaults to `false`. When set to `true`, it hints to the browser that it should hide the "back to tab" button, illustrated in the below image, which by default appears in the top bar of the Picture-in-Picture window. | ||
|
|
||
|  | ||
|
|
||
| The "back to tab" button hides the window when pressed, returning focus to the spawning tab. |
There was a problem hiding this comment.
Suggested change
| - : A boolean value; defaults to `false`. When set to `true`, it hints to the browser that it should hide the "back to tab" button, illustrated in the below image, which by default appears in the top bar of the Picture-in-Picture window. | |
|  | |
| The "back to tab" button hides the window when pressed, returning focus to the spawning tab. | |
| - : A boolean value; defaults to `false`. When set to `true`, this option hints to the browser that it should not display a UI control that enables the user to return to the original page and close the Picture-in-Picture window. Defaults to `false`. |
This suggestion is more or less just from the spec. I don't think including a screenshot of one implementation of the UI is particularly useful, and I don't think "by default appears in the top bar of the Picture-in-Picture window" is accurate per spec, rather than being a description of the current Chrome implementation. Also I think the "back to tab" button hides the window isn't quite accurate: it closes the window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds documentation for two new options available to the
DocumentPictureInPicture.requestWindow()method:disallowReturnToOpeneroption. When set totrue, it hides the "back to tab" button that by default appears in the top bar of the PIP window. See https://chromestatus.com/feature/6223347936657408.preferInitialWindowPlacementoption. When set totrue, it causes the PIP window to always appear back at its default initial position and size when closed and then reopened. By default, it will reopen at its previous position and size. See https://chromestatus.com/feature/5183881532932096.I've tested that both features work in the latest Chrome, but I've not tested exact versions in detail.
Motivation
Additional details
Related issues and pull requests