Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Documents Function and fixed issued #772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Er-Sadiq
Copy link

Description
This PR introduces the updateDocumentsByFunction method to the Documents class in the Meilisearch SDK. This method enables updating documents in a specified index based on a provided function.

Changes:

Added Method: Implemented the updateDocumentsByFunction method in Documents.java.
Allows updating documents using a function via the new /indexes/:uid/documents/edit API endpoint.
Includes error handling for null or empty function parameters.
Returns a TaskInfo object that provides details about the task created.
Addresses issue #769, which requests the addition of document updates via a function.

@curquiza
Copy link
Member

curquiza commented Oct 1, 2024

Hello @Er-Sadiq
Sorry for the delay

The test does not pass. I will review once the CI is green 😊

@Er-Sadiq
Copy link
Author

Er-Sadiq commented Oct 1, 2024

@curquiza Sure ,No Problem..
Let me know if there is to fix something on fix or any improvements you are looking for
Thank you ..

@curquiza
Copy link
Member

curquiza commented Oct 1, 2024

@Er-Sadiq
Check the CI result below to know what do fix
Capture d’écran 2024-10-01 à 18 46 16

And/or run the test locally to ensure you push commits that pass the tests 😊

@curquiza curquiza changed the title Updated Documents Function and fixed issued:#769 Updated Documents Function and fixed issued Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants