-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(targets): Added a new prepare_table_columns
method to the SQLConnector
base class
#2354
Open
raulbonet
wants to merge
11
commits into
meltano:main
Choose a base branch
from
raulbonet:rb/2353/prepare_table_columns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e663489
feat: prepare_table_columns
raulbonet c1999df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9bec6ca
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon c682641
Update singer_sdk/connectors/sql.py
edgarrmondragon ba2d93f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8a679f3
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon acca24f
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon a06b8de
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon 47b6477
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon cf65b1a
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon 526aa3e
Merge branch 'main' into rb/2353/prepare_table_columns
edgarrmondragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -854,12 +854,42 @@ def prepare_table( | |
) | ||
return | ||
|
||
self.prepare_table_columns( | ||
full_table_name=full_table_name, | ||
schema=schema, | ||
) | ||
|
||
def prepare_table_columns( | ||
self, | ||
full_table_name: str, | ||
schema: dict, | ||
) -> None: | ||
"""Adapt target table columns to provided schema if possible. | ||
|
||
The advantage of encapsulating this in a separate method is that we reduce | ||
the number of calls to the database by calling get_table_columns() only once | ||
per table. | ||
|
||
Args: | ||
full_table_name: the target table name. | ||
schema: the JSON Schema for the table. | ||
""" | ||
columns = self.get_table_columns( | ||
full_table_name=full_table_name, | ||
) | ||
for property_name, property_def in schema["properties"].items(): | ||
self.prepare_column( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add a deprecation warning when this function is called? |
||
full_table_name, | ||
property_name, | ||
self.to_sql_type(property_def), | ||
) | ||
if property_name not in columns: | ||
self._create_empty_column( | ||
full_table_name=full_table_name, | ||
column_name=property_name, | ||
sql_type=self.to_sql_type(property_def), | ||
) | ||
else: | ||
self._adapt_column_type( | ||
full_table_name, | ||
column_name=property_name, | ||
sql_type=self.to_sql_type(property_def), | ||
) | ||
|
||
def prepare_column( | ||
self, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should tests for this.
tests/core/test_connector_sql.py
might a good place for that.