Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Interruption and termination signals are handled in taps and targets #2620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 22, 2024

Closes #129


📚 Documentation preview 📚: https://meltano-sdk--2620.org.readthedocs.build/en/2620/

Copy link

codspeed-hq bot commented Aug 22, 2024

CodSpeed Performance Report

Merging #2620 will not alter performance

Comparing edgarrmondragon/feat/signals (f87387e) with main (2a3d3fa)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (3de2b98) to head (f87387e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
+ Coverage   89.67%   89.72%   +0.04%     
==========================================
  Files          58       58              
  Lines        4854     4857       +3     
  Branches      950      949       -1     
==========================================
+ Hits         4353     4358       +5     
+ Misses        350      348       -2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/signals branch 2 times, most recently from 57ed344 to b795525 Compare August 22, 2024 02:45
@edgarrmondragon edgarrmondragon changed the title feat: Interruption and termination signals in taps and targets feat: Interruption and termination signals are handled in taps and targets Aug 22, 2024
@edgarrmondragon edgarrmondragon self-assigned this Aug 22, 2024
@edgarrmondragon edgarrmondragon added kind/Feature New feature or request Release Highlight Call this out in the release notes labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request Release Highlight Call this out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle SIGTERM messages to shut down gracefully
1 participant