Build uses OS and ARCH variables.

[pastushenkoy]

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Fixes #128

Proposed Changes

• Adds local build description
• Fixes makefile

Description

Checklist

• Read the CONTRIBUTING document.
• Read the CODE OF CONDUCT document.
• Add tests to cover changes.
• Ensure your code follows the code style of this project.
• Ensure CI and all other PR checks are green OR
  • Code compiles correctly.
  • Created tests which fail without the change (if possible).
  • All new and existing tests passed.
• Add your changes to Unreleased section of CHANGELOG.
• Improve and update the README (if necessary).
• Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

[kakkoyun]

Thanks for the PR. This would help to contributors.
CI is failing though, could you have a look at it? Maybe you should consider using GOOS and GARCH and extract them using go tool rather than using the variables that we generated using uname

[kakkoyun]

Suggested change

	CONTAINER_REPO=<your-container-reginstry-address>/drone-cache OS=linux ARCH=amd64 make container-push
	CONTAINER_REPO=<your-container-registry-address>/drone-cache OS=linux ARCH=amd64 make container-push

[pastushenkoy]

@kakkoyun I suggest using linux and 'amd64` as defaults. This is most popular combination, I think.
Nevertheless, I would like to keep OS and ARCH variables to separate build args from implementation details.

But when now liche is protesting. Can you explain how to fix this issue with docs generation to not bother you next time?

[kakkoyun]

Let's not hard code OS and ARCH values.

CI failing because documentation generation issues. Try make docs or make README.md and commit changes. This is not relevant to your changes, it'd be great if you can just check them in.

[kakkoyun]

Why are we hard-coding these? Without these parameters go tool itself pretty clever to determine the os and architecture by given these default you introduce a regression for user. They need to specify those to build. This is not what we want.

[pastushenkoy]

I, for example, use macbook for development and if I build container without specifying OS, I get darwin. This leads to runtime error as my drone uses linux to execute pipelines. I really doubt that anyone would do it on macos, but for those who would, goreleaser will make correct images.
As for ARCH, uname returns x86_64 instead of amd64. It leads to error when building container.
As far as I understand, the build command is used only in drone pipeline to ensure that build is not broken and for local build and development. For these purposes these values can and should be hardcoded.

[kakkoyun]

This is not a change that we want to accept. These command is to build container if it needs to be tested locally. One can easily override defaults for their target platform. I don't see any value in hardcoding these variables. Closing for now.

Thanks a lot for contribution in any case.