fix: lint

pkg/pod/pod.go

@@ -1,10 +1,11 @@
 package pod
 
 import (
-	"github.com/mercari/tortoise/api/v1beta3"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/utils/ptr"
+
+	"github.com/mercari/tortoise/api/v1beta3"
 )
 
 type Service struct {
@@ -24,10 +25,10 @@ func New(
 	}, nil
 }
 
-func (s *Service) ModifyPodResource(pod *v1.Pod, t *v1beta3.Tortoise) *v1.Pod {
+func (s *Service) ModifyPodResource(pod *v1.Pod, t *v1beta3.Tortoise) {
 	if t.Spec.UpdateMode == v1beta3.UpdateModeOff {
 		// DryRun, don't update Pod
-		return pod
+		return
 	}
 
 	oldRequestsMap := map[containerNameAndResource]resource.Quantity{}
@@ -80,8 +81,6 @@ func (s *Service) ModifyPodResource(pod *v1.Pod, t *v1beta3.Tortoise) *v1.Pod {
 			pod.Spec.Containers[i].Resources.Limits[k] = *newLim
 		}
 	}
-
-	return pod
 }
 
 type containerNameAndResource struct {

pkg/pod/pod_test.go

@@ -4,9 +4,10 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/mercari/tortoise/api/v1beta3"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
+
+	"github.com/mercari/tortoise/api/v1beta3"
 )
 
 func TestService_ModifyPodResource(t *testing.T) {
@@ -456,7 +457,8 @@ func TestService_ModifyPodResource(t *testing.T) {
 				resourceLimitMultiplier: tt.fields.resourceLimitMultiplier,
 				minimumCPULimit:         tt.fields.minimumCPULimit,
 			}
-			got := s.ModifyPodResource(tt.args.pod, tt.args.tortoise)
+			got := tt.args.pod.DeepCopy()
+			s.ModifyPodResource(got, tt.args.tortoise)
 			if d := cmp.Diff(got, tt.want); d != "" {
 				t.Errorf("ModifyPodResource() mismatch (-want +got):\n%s", d)
 			}