aucoalesce: Be more forgiving of compound events. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoalesceMessages function takes one or more audit messages and creates an Event object. An Event containing more than one message is known as a "compound event". Prior to this commit, the compound event parsing logic required that a "syscall" message be included in the slice passed to the function. This requirement may be a little over-zealous. In GitHub issue 127, we discovered examples of audit events that did not include a syscall message. [1] This resulted in CoalesceMessages returning an error. This commit modifies the syscall message check to only return an error if both the "special" and syscall audit messages are missing. In such a case, a new (testable) error is returned. 1. elastic/go-libaudit#127
JAORMX
approved these changes
Mar 13, 2023
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 13, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 13, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
stephen-fox
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
JAORMX
pushed a commit
to metal-toolbox/audito-maldito
that referenced
this pull request
Mar 14, 2023
Refer to the following URLs for more information: - metal-toolbox/go-libaudit#3 - elastic/go-libaudit#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoalesceMessages function takes one or more audit messages and creates an Event object. An Event containing more than one message is known as a "compound event".
Prior to this commit, the compound event parsing logic required that a "syscall" message be included in the slice passed to the function. This requirement may be a little over-zealous. In GitHub issue 127, we discovered examples of audit events that did not include a syscall message. [1] This resulted in CoalesceMessages returning an error.
This commit modifies the syscall message check to only return an error if both the "special" and syscall audit messages are missing. In such a case, a new (testable) error is returned.