Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goreleaser configuration #423

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Update goreleaser configuration #423

merged 5 commits into from
Aug 28, 2024

Conversation

kyleam
Copy link
Collaborator

@kyleam kyleam commented Aug 27, 2024

The goreleaser action requires version 2 of the config format.

The goreleaser job in .github/workflows/main.yaml failed with

  only configurations files on version: 2 are supported, yours is
  version: 0 , please update your configuration

Update the config file based on the current documentation.

At least according to 'goreleaser check', this is config is now valid.
The builtin GITHUB_TOKEN should be sufficient for goreleaser to make a
release in _this_ repository, but a custom token is needed in order to
push to a different repository than the one workflow is running in
(metrumresearchgroup/homebrew-tap in this case).

Set GH_GORELEASER_BREWS_TOKEN in the environment.  (The previous
commit updated the brew's section of the goreleaser config to use
this.)
cmd/pkgr/goreleaser.yml expects this to be defined.
These days we update the top of the release with the NEWS entries for
the release, so it makes sense to have goreleaser publish it as a
draft.
@kyleam kyleam marked this pull request as ready for review August 27, 2024 21:31
@kyleam
Copy link
Collaborator Author

kyleam commented Aug 27, 2024

Wired up and successfully created a release

https://github.com/metrumresearchgroup/pkgr/actions/runs/10585876331/job/29333921131

https://github.com/metrumresearchgroup/pkgr/releases/tag/v3.1.2-rc.1

metrumresearchgroup/homebrew-tap@5d68570

(Note: I removed the auto-generated changelog entries from there. I think we should eventually configure goreleaser to not add those, but I haven't made that adjustment here.)

@kyleam kyleam requested a review from seth127 August 27, 2024 21:33
@kyleam
Copy link
Collaborator Author

kyleam commented Aug 27, 2024

Checked artifacts on macOS and Linux (pkgr --version and pkgr inspect --help).

Our current practice is to manually add the release's entries from
NEWS.md to the release.
@kyleam
Copy link
Collaborator Author

kyleam commented Aug 28, 2024

I removed the auto-generated changelog entries from there. I think we should eventually configure goreleaser to not add those, but I haven't made that adjustment here.

Done in d92447c. That's after the tag here but will be in effect for the next tag. That setting was tested in metrumresearchgroup/bbi#332 and worked as expected.

Copy link
Collaborator

@seth127 seth127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@kyleam kyleam merged commit 30c87f0 into main Aug 28, 2024
3 checks passed
@kyleam kyleam deleted the goreleaser-update branch August 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants