Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SessionIdentifierAwareInterface #71

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

alexmerlin
Copy link
Contributor

Q A
Documentation yes
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

As requested in #59 this commit:

  • adds SessionIdentifierAwareInterface's getId() method to SessionInterface
  • removes SessionIdentifierAwareInterface

Also, adds v2 documentation.

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look 👍 - Just the redirects need updating

mkdocs.yml Show resolved Hide resolved
@gsteel gsteel added this to the 2.0.0 milestone Aug 19, 2024
@gsteel gsteel linked an issue Aug 19, 2024 that may be closed by this pull request
@alexmerlin alexmerlin requested a review from gsteel August 20, 2024 05:23
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @alexmerlin - I've just been checking the implementations due to the removed test testGetIdReturnsEmptyStringIfNoIdentifierProvidedToConstructor, and the session id is expected to be ''|non-empty-string. This is used to signal to persistence implementations that the session needs to be regenerated - My fault. It might have been clearer for the id to be typed as null|non-empty-string but it's not worth changing this for all the implementations.

I should have checked this out properly before opening my mouth! So the addition of non-empty-string needs to be reverted.

For future reference, the @psalm- prefix is generally unnecessary. Most IDEs along with Psalm and PHPStan understand non-empty-string and most other annotations. Notable exceptions to this rule are @psalm-type and @psalm-import-type

@alexmerlin alexmerlin requested a review from gsteel August 20, 2024 09:41
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexmerlin 👍

@gsteel gsteel self-assigned this Aug 20, 2024
@gsteel gsteel merged commit 9c6d475 into mezzio:2.0.x Aug 20, 2024
14 of 15 checks passed
@alexmerlin alexmerlin deleted the issue-59-v2 branch August 20, 2024 10:00
@froschdesign
Copy link
Member

@alexmerlin @gsteel
Please make sure that all changes in the history are visible. The changes to the documentation are not available here as a separate pull request/commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate SessionIdentifierAwareInterface for removal in v2.0
3 participants