Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cmake package install #535

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve cmake package install #535

wants to merge 3 commits into from

Conversation

Faroito
Copy link

@Faroito Faroito commented Jul 19, 2024

This MR tries to uses more modern CMake mecanism for libtins config file. The main changes are:

  • Make installed package relocatable by making path relatives to the install tree (related to Make package relocatable (fixes #101) #107)
  • Install FindPCAP.cmake in the install tree to be able to find automatically the dependency when searching for libtins
  • Set the include directory interface directly on target

It also fixes #101

@Faroito
Using same cmake config path for all OS
e30f57b
@Faroito
Add a target for found PCAP library
c4dbee5
@Faroito
Improve libtins config cmake file
c21bb1a 
- Use CMakePackageConfigHelpers macro to generate the config file.
- Uses relative path to seach for libtins includes.
- Install the FindPCAP.cmake file & search for PCAP dependency
- Set the include directory interface directly on target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installed package not relocatable
1 participant
@Faroito