Meta data added

[andriks2]

Added meta properties CategoryAttribute and DescriptionAttribute. Also fixed typo in comments for ZXing.OneD.Code128EncodingOptions

[micjahn]

Thanks for the PR.
Can you please check the following commit:
b3e5f17
There is something wrong because it adds the complete class PDF417EncodingOptions instead of only the necessary attributes. The automatic AppVeyor build fails.

[andriks2]

Michael, Probably I did something wrong, I have used a number of version control systems in my programming career, but never GitHub. I forked the master branch of ZXing.Net, dragged the six changed files from Total Commander to what I assumed to be the correct position of the files in my fork1) in the webbrowser window and dropped it. I could have sworn I saw the change history update to ‘x minutes ago’, but now when navigating to it, it says ‘11 months ago’. And my changes are not in the file. In the location you send to me, I indeed see that GitHub now talks of a new file, probably because ‘This commit does not belong to any branch on this repository’. I do not know where the update version of the file went to, but not the page I saw in my browser when doing the drag/drop. Can you explain briefly how to get my changes committed without having to edit the file in situ. Maybe a github desktop client? Greetings, André 1)E.g. navigate to <https://github.com/andriks2/ZXing.Net/tree/master/Source/lib/pdf417/encoder> https://github.com/andriks2/ZXing.Net/tree/master/Source/lib/pdf417/encoder Van: Michael Jahn <[email protected]> Verzonden: woensdag 19 augustus 2020 21:24 Aan: micjahn/ZXing.Net <[email protected]> CC: andriks2 <[email protected]>; Author <[email protected]> Onderwerp: Re: [micjahn/ZXing.Net] Meta data added (#272) Thanks for the PR. Can you please check the following commit: <b3e5f17> b3e5f17 There is something wrong because it adds the complete class PDF417EncodingOptions instead of only the necessary attributes. The automatic AppVeyor build fails. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#272 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKHRNVQTT44WPYAE7MBWONDSBQRDRANCNFSM4QFBRCJQ> .

[andriks2]

Hi team, A few points for the person responsible for the development of BarcodeReaderGeneric And BaseLuminanceSource. While playing with the WindowsFormDemo I tried to decode a number of images. Two things stood out: * If decoding �fails� I sometimes get a lot of found PharmaCodes. Given the very forgiving specs for that code I think there is not much one can do, other than be suspicious if multiple pharmacode found in one decode operation. * Decoding often fails when the image is rotated in an angle near 45 degrees. My first idea was to implement 45 degree rotation logic in BarcodeReaderGeneric, but that only got me NotImplemented exceptions. Upon inspection I noticed that in BaseLuminanceSource the code for rotateCounterClockwise45 is not implemented. Some questions regarding the latter. First, there is no separate property to check if a Reader implements 45 degree rotation, so it impossible for the user to check if the RotateSupported Propertry does or does not imply that 45 degree rotation is supported. Should not both RotateSupported and RotateSupported45 be implemented? Is there a reason that rotateCounterClockwise45 Is not simply implemented as follows? byte[] rotatedLuminances = new byte[Width * Height]; byte[] localLuminances = Matrix; int newWidth = Width; // ? make bigger by Sqrt(2) int newHeight = Height; double xC = 0.5 * Width; double yC = 0.5 * Height; double sin315 = Math.Sin(Math.PI * 315.0 / 180.0); double cos315 = Math.Cos(Math.PI * 315.0 / 180.0); for (var yold = 0; yold < Height; yold++) { for (var xold = 0; xold < Width; xold++) { int xnew = (int)(xC + ((xold - xC) * cos315 - (yold - yC) * sin315)); int ynew = (int)(yC + ((xold - xC) * sin315 + (yold - yC) * cos315)); if ((xnew >= 0) && (xnew < newWidth) && (ynew >= 0) && (ynew < newHeight)) rotatedLuminances[ynew * newWidth + xnew] = localLuminances[yold * Width + xold]; } } return CreateLuminanceSource(rotatedLuminances, newWidth, newHeight); The current comment says �// TODO: implement a good 45 degrees rotation without loss of information�. My testcases mostly run fine, so maybe I am missing something because I am new to the project? But then, something may be better than nothing? And for Michael: I now have installed GitHubDesktop and will try updating my fork soon. Yours, André Hendriks

[micjahn]

Michael, Probably I did something wrong, I have used a number of version control systems in my programming career, but never GitHub. I forked the master branch of ZXing.Net, dragged the six changed files from Total Commander to what I assumed to be the correct position of the files in my fork1) in the webbrowser window and dropped it. I could have sworn I saw the change history update to ‘x minutes ago’, but now when navigating to it, it says ‘11 months ago’. And my changes are not in the file. In the location you send to me, I indeed see that GitHub now talks of a new file, probably because ‘This commit does not belong to any branch on this repository’. I do not know where the update version of the file went to, but not the page I saw in my browser when doing the drag/drop. Can you explain briefly how to get my changes committed without having to edit the file in situ. Maybe a github desktop client? Greetings, André 1)E.g. navigate to https://github.com/andriks2/ZXing.Net/tree/master/Source/lib/pdf417/encoder https://github.com/andriks2/ZXing.Net/tree/master/Source/lib/pdf417/encoder Van: Michael Jahn [email protected] Verzonden: woensdag 19 augustus 2020 21:24 Aan: micjahn/ZXing.Net [email protected] CC: andriks2 [email protected]; Author [email protected] Onderwerp: Re: [micjahn/ZXing.Net] Meta data added (#272) Thanks for the PR. Can you please check the following commit: <b3e5f17> b3e5f17 There is something wrong because it adds the complete class PDF417EncodingOptions instead of only the necessary attributes. The automatic AppVeyor build fails. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#272 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHRNVQTT44WPYAE7MBWONDSBQRDRANCNFSM4QFBRCJQ .

Forking is easy, in my opinion. I'm not sure if I made everything right but here is a short explanation of how I contribute to other projects.

1. I make a fork of the project
2. I make a new branch for the changes I want to make, f.e. in your case I would have made a branch "property-attributes" or similar
3. I make a local repository clone and switch it to the created branch
4. I make my changes, commit them to my local repo clone and push them to github into my fork
5. I create a new pull request at github
6. after the PR is merged I remove my feature branch ("property-attributes")
7. I pull the merge changes from the original repository to my own fork into the master branch
   https://guides.github.com/activities/forking/

[micjahn]

A few points for the person responsible for the development of BarcodeReaderGeneric And BaseLuminanceSource.

I'm the only member of the ZXing.Net team. It is, more or less, a one-man-show. From time to time there are contributions from others (like you).
The original project is written in java (github.com/zxing/zxing). I created this C# version here based upon the java original.

If decoding fails I sometimes get a lot of found PharmaCodes

Pharmacode and MSI aren't activated by default (too many false positives). Take a look at BarcodeFormat.All1D.
If someone want's to decode them they have to be activated explicitly (barcode reader options).

rotation by 45 degree

It isn't implemented yet because it isn't that easy like 90 degrees. Your sample code looks promising.
But you have to calculate a new width and height. They should be as big as the diagonals of the original rectangle.
There should be some optimization possible to do fewer multiplications
(like calculating the mirrored point only with additions and subtractions).
You should create a new branch within your fork and create a new pull request for the rotation by 45 degrees.