Specify the result of decoding (QR, Datamatrix, AZTEC and MaxiCode) as byte[] #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the content readed before being submited to a specific encoding
…) for QR and Datamatrix -> corrected ADD-HOC solution
micjahn
requested changes
Oct 19, 2022
| @@ -77,6 +77,8 @@ internal static DecoderResult decode(byte[] bytes, int mode) | |||
| } | |||
| String country = getCountry(bytes).ToString(THREE_DIGITS); | |||
| String service = getServiceClass(bytes).ToString(THREE_DIGITS); | |||
|
|
|||
| var msg = getMessage(bytes, 10, 84); | |||
There was a problem hiding this comment.
this should not be necessary, I think
| @@ -95,7 +97,7 @@ internal static DecoderResult decode(byte[] bytes, int mode) | |||
| break; | |||
| } | |||
|
|
|||
| return new DecoderResult(bytes, result.ToString(), null, mode.ToString()); | |||
| return new DecoderResult(bytes, Encoding.UTF8.GetBytes(result.ToString()), result.ToString(), null, mode.ToString()); | |||
There was a problem hiding this comment.
In my opinion, that default behavior (UTF8.GetBytes(...)) should better be placed in the Result class because it would be cleaner to see what class really gives the byte data (like the qr code implementation).
| @@ -66,7 +66,7 @@ public Result decode(BinaryBitmap image, IDictionary<DecodeHintType, object> hin | |||
| if (decoderResult == null) | |||
| return null; | |||
|
|
|||
| var result = new Result(decoderResult.Text, decoderResult.RawBytes, NO_POINTS, BarcodeFormat.MAXICODE); | |||
| var result = new Result(decoderResult.Text, decoderResult.Data, decoderResult.RawBytes, NO_POINTS, BarcodeFormat.MAXICODE); | |||
There was a problem hiding this comment.
should be reverted, see the comment at DecodedBitStreamParser.cs; Result class can generate the value of Data property if the reader doesn't give a better value.
| { | ||
| if (text == null && rawBytes == null) | ||
| { | ||
| throw new ArgumentException("Text and bytes are null"); | ||
| } | ||
| Text = text; | ||
| Data = data; |
There was a problem hiding this comment.
this could be a good place to add the default behavior UTF8.GetBytes(text) if data == null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm using ZXing.Net.Mobile.Forms, which in turn uses ZXing.Net in a specific Xamarin.Forms mobile project. So I'm absolutely not an expert in the process of barcode decoding. In short, that project scans a barcode that contains some data. However, this data has not 'string' specific format, so we, in fact, want the data as binary. Now we are only using 2 implementations of barcode: Datamatrix and QR. Datamatrix, no problem, we were getting the data by encode the string with ISO-8859-1 and no problem, we could get it. Nevertheless, with QR, that's not the same. When we tried to encode this string with ISO-8859-1 we had lose a lot of information (some characters were mapped to 3f == '?'). So we propose this little alteration, in order to return the text result along with the binary information used to achieve it when applying a specific encoding.