Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev site warning banner; display it on GH Pages site #168

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes #166

This is just a quick 'n' dirty change to show a warning banner on the GH Pages site. The goal is to warn people about using it while we decide its ultimate fate (#167).

A new environment variable controls whether the warning banner is shown or not. The environment variable does not get set in any of the existing .env.* files. Rather it just gets set as the site is built in the GH Pages deploy workflow.

Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for implementing this. I'll merge it in now. That will make it live on the PWA (website).

@eecavanna eecavanna merged commit bb61975 into main Sep 5, 2024
1 check passed
@eecavanna eecavanna deleted the issue-166-dev-warning-banner branch September 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add banner to GitHub Pages site indicating that it is not a production site
3 participants