Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make submission portal login prompt be more prominent #1188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Mar 15, 2024

In this PR branch, I updated the submission portal login prompt so that it would be more obvious to visitors that they won't be able to submit data unless they login. That was based upon this feedback.

Here's what the updated login prompt looks like:

image

For comparison, here's what the login prompt looks like today:

image

@eecavanna eecavanna self-assigned this Mar 15, 2024
@eecavanna eecavanna marked this pull request as ready for review March 15, 2024 22:29
Comment on lines +21 to +23
<h3 class="text-h6 font-weight-bold mb-3">
Login to submit data
</h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use the h3 tag then re-assign the style as h6 mainly because I don't think the h3 is necessary here and becomes confusing.

Comment on lines +21 to +25
<h3 class="text-h6 font-weight-bold mb-3">
Login to submit data
</h3>
<p class="body-1">
Login with your ORCID iD
to access the Submission Portal.
Login with your ORCID iD to submit data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the repetition here is unnecessary and makes the layout a bit awkward

@marySalvi
Copy link
Collaborator

Personally I think the grey background is the biggest culprit here and making the text bolder and longer is making the alert a bit awkward. I played around with it a bit and came up with this:

Screenshot from 2024-03-15 19-48-13

Screencast.from.03-15-2024.08.02.09.PM.webm

I think a brighter color and shorter text makes it stand out. What are your thoughts @eecavanna

@eecavanna
Copy link
Collaborator Author

eecavanna commented Mar 16, 2024

Hi @marySalvi, I like that purple version. If you still have the code for that, will you post a patch here (copy/pasting it into a ```diff block in a comment would be OK with me)?

# To generate the patch:
git diff web/src/views/SubmissionPortal/Components/LoginPrompt.vue > my-patch.diff.txt

Edit: I have the patch on my local machine now (we followed up via Slack).

@mslarae13
Copy link

#1187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Update submission portal landing page to emphasize the need to login before submitting
3 participants