Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show per-workflow and per-filetype sizes in bulk download #1352

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

naglepuff
Copy link
Collaborator

@naglepuff naglepuff commented Aug 21, 2024

Fix #1344

Changes

Modifies the query used by the /data_object/workflow_summary endpoint to include a sum of the sizes of the data objects at the workflow type and file type level. Updates the frontend to display these sizes (if non-zero) in the bulk download control

Testing

Check out the new labels for the tree view in the bulk download control! They also show up when you select file types to add to the bulk download:
image

Modifies the query to include a `SUM` of data objects grouped by workflow/type.
Coalesces values to 0 in case they are null. Also updates the schema used as the
return type for the `/data_object/workflow_summary` endpoint.
Update the type definition for the response from `data_object/workflow_summary` and
update the display strings in the bulk download component.
Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@naglepuff naglepuff merged commit feac95b into main Aug 23, 2024
2 checks passed
@naglepuff naglepuff deleted the 1344-bulk-download-size branch August 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement aggregate file size information for bulk download
2 participants