Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New+ Windows 10 support #35832

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

cgaarden
Copy link
Contributor

@cgaarden cgaarden commented Nov 8, 2024

Summary of the Pull Request

This PR provides New+ support for Windows 10.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Added Windows 10 support, without breaking Windows 11 support

Validation Steps Performed

Windows 10

  1. Installed on clean Windows 10 Home version (en_US)
  2. (test-signing is not needed)
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

Windows 11

  1. Installed on clean Windows 11 Sandbox (en_US)
  2. Manually test-signed
  3. Desktop: Icon view: Tier 1 context menu New+ folder and files
  4. In folder on Desktop: Detailed view: Tier 1 context menu New+ folder and files
  5. Reviewed logs in NewPlus.ShellExtension\Logs\v0.0.1

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@cgaarden cgaarden marked this pull request as ready for review November 10, 2024 04:23
@cgaarden cgaarden changed the title Windows 10 experimental support New+ Windows 10 support Nov 10, 2024
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

POSITIONITEM

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:cgaarden/PowerToys.git repository
on the Windows-10-provisional-support branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/11874084963/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1921) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant